Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renaming FIPS classifier to be more clear #773

Merged
merged 5 commits into from
Mar 20, 2024
Merged

Conversation

TingDaoK
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@TingDaoK TingDaoK changed the title renaming and add more warning renaming FIPS classifier to be more clear Mar 20, 2024
@TingDaoK TingDaoK marked this pull request as ready for review March 20, 2024 17:29
README.md Outdated
* **NOT compliant**: linux-armv6, linux-armv7, linux-armv7-musl, linux-aarch_64-musl, linux-x86_32, linux-x86_64-musl, osx-aarch_64, osx-x86_64, windows-x86_32, windows-x86_64

> [!WARNING]
> The classifier and the platforms with FIPS compliant are subjected to be changed in the future.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> The classifier and the platforms with FIPS compliant are subjected to be changed in the future.
> The classifier, and platforms with FIPS compliance are subject to change in the future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fips-compat-jar-build.yml - > fips-where-available-jar-build.yml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'd need to update the release pipeline too, right? I can't find where this file is referenced, in the codebase

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's in the codebuild process

@TingDaoK TingDaoK merged commit b04445e into main Mar 20, 2024
42 checks passed
@TingDaoK TingDaoK deleted the update-classifier-naming branch March 20, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants